Add options settings - Githubissues

ljharb / repo-report

CLI to list all repos a user has access to, and report on their configuration in aggregate.

MIT License

24 stars 11 forks source link

Add options settings #6

Closed diananova closed 3 years ago

diananova commented 3 years ago

fields added so far:

wiki
projects
securityPolicy (not sure if this can be useful)
mergeCommit
squashMerge
rebaseMerge
deleteBranchOnMerge

notes:

not sure if owner is necessary here. Should we remove it?
I also noticed that in mappedFields the logSymbols control is not necessary, because we do it in tables.push
this is a draft pr for now. Not ready for merge. Just wanted to share my progress and see if everything is ok so far.

ljharb commented 3 years ago

What I'd probably do is list the repository slug rather than the owner separately - iow, diananova/phone-book instead of both of those columns.

thehanimo commented 3 years ago

I also noticed that in mappedFields the logSymbols control is not necessary, because we do it in tables.push

We actually use it over here: https://github.com/ljharb/repo-report/blob/5e0b282cfd3bcc490eb14182f81ceb93260b8e19/src/commands/list.js#L76

It is invoked when you group the output by isPublic.

We don't use it when the output isn't going to be grouped here: https://github.com/ljharb/repo-report/blob/5e0b282cfd3bcc490eb14182f81ceb93260b8e19/src/commands/list.js#L91-L99

We could (and probably should) use it over there as well like so:

repositories.forEach((item) => {
    table.push(mappedFields.map((func) => func(item)));
});

Nice catch!!

diananova commented 3 years ago

should we use slug for command list as well? @thehanimo
I think the repos are sorted by date (oldest ones first). So we can add sort alphabetically

diananova commented 3 years ago

there are some fields missing that I couldn't find. For ex.

Allow auto-merge
Archives (Include Git LFS objects in archives )
Restrict editing to collaborators

@jakazzy would you like to look into this? Also, feel free to add other fields that you think might be useful.

(btw sorry for opening a duplicated branch 5-options-list, it would be nice to delete it if possible. I was trying to get rid of all the extra commits).

sladyn98 commented 3 years ago

@diananova Great PR can you rebase this with master :)

diananova commented 3 years ago

@diananova Great PR can you rebase this with master :)

Ok done!