ljharb / repo-report

CLI to list all repos a user has access to, and report on their configuration in aggregate.
MIT License
24 stars 11 forks source link

[Refactor] extract metrics to a single source of truth #60

Closed rosekamallove closed 2 years ago

rosekamallove commented 2 years ago
rosekamallove commented 2 years ago

Hey, can you please review it?

rosekamallove commented 2 years ago

A small question, should I push the test in the PR or create a new one for it?

ljharb commented 2 years ago

Refactors don't generally need tests; if you have a unit test in mind for the Metrics file that's testing structure but not hardcoding expected metric contents, then it'd be great to add that here.

ljharb commented 2 years ago

Actually I'm going to land as-is; we can add the test later if you're inclined.

rosekamallove commented 2 years ago

We can talk about this in detail tomorrow at the meeting.