Closed rosekamallove closed 2 years ago
Hey, can you please review it?
A small question, should I push the test in the PR or create a new one for it?
Refactors don't generally need tests; if you have a unit test in mind for the Metrics file that's testing structure but not hardcoding expected metric contents, then it'd be great to add that here.
Actually I'm going to land as-is; we can add the test later if you're inclined.
We can talk about this in detail tomorrow at the meeting.