search

ljharb / repo-report

CLI to list all repos a user has access to, and report on their configuration in aggregate.
MIT License
24 stars 11 forks source link

Add tests for Metrics Object #61

Closed rosekamallove closed 2 years ago

rosekamallove commented 2 years ago
rosekamallove commented 2 years ago

Hey, @ljharb What more tests can I add?

rosekamallove commented 2 years ago

Should I write a test for dontPrint and compare too?

rosekamallove commented 2 years ago

Hey @ljharb, I was thinking that I can call the jsonschema validator in a test in utils.test.js as a test but I am not sure where to write it?

ljharb commented 2 years ago

That plan seems fine! I'd expect the schema to be a separate .json file, is all.

rosekamallove commented 2 years ago

Okay, I'll just create a metricsSchema.json in the test/fixtures folder

rosekamallove commented 2 years ago

Hey @ljharb Can you take a look?