search

ljleb / prompt-fusion-extension

auto1111 webui extension for all sorts of prompt interpolations!
MIT License
259 stars 16 forks source link

Fractional step values for 1.6.0 hires prompt editing does not work #62

Closed ljleb closed 9 months ago

ljleb commented 11 months ago

Fractional step values for hires prompt editing, i.e. [wolf : dog : 1.5] are broken by this extension. It does not prevent generation, but the values are cast to int and taken as step numbers, which is wrong.

SirVeggie commented 9 months ago

Any ETA on this fix?

ljleb commented 9 months ago

5 minutes.

SirVeggie commented 9 months ago

Amazing

SirVeggie commented 9 months ago

Seems like it did not quite work. Now the resulting image is quite close to the expected result but there is still something wrong, [::1.1] and [::1.9] produce an almost identical image, whereas the difference is somewhat bigger when the extension is disabled.

ljleb commented 9 months ago

This is because in the background the extension converts float steps to step indices no matter what. Will push a fix shortly.

ljleb commented 9 months ago

I did test the feature a little bit. Except for a few cases I may have missed, the new syntax should work. You should also be able to use the previous syntax by checking the "use old prompt editing timelies" checkbox in the compatibility options.

SirVeggie commented 8 months ago

After using it for quite some time, I do think it is working well now.