search

ljleb / sd-webui-freeu

a1111 implementation of https://github.com/ChenyangSi/FreeU
MIT License
303 stars 16 forks source link

The xyz grid option "[FreeU] Enabled" is confusing #34

Closed YKefasu closed 1 year ago

YKefasu commented 1 year ago

xyz_grid-0013-1384322262

ljleb commented 1 year ago

The xyz choice "[FreeU] Enabled" toggles the enable checkbox itself. It overrides the checkbox, whether it is visually ticked or not in the accordion. I see how this could be confusing, but I believe it would be even more confusing for the xyz grid to change nothing when the checkbox is initially false in the ui.

I'm open to suggestions on the design, let me know if you have another idea.

ljleb commented 1 year ago

I'm not able to reproduce the issue if you do run into this without the XYZ grid script. I also tried to generate with the XYZ grid with "False, True" so that it finishes on True, and then disable it to see if the XYZ grid script leaves the checkbox checked as a side effect, to no avail.

If you find a consistent way to reproduce the issue, please send step by step instructions so that I can reproduce the situation.

YKefasu commented 1 year ago

Sorry for bothering. I noticed a drastic difference in the results due to the NV random number generator source. Now, it's fine with the GPU image

ljleb commented 1 year ago

No problem! Glad you found a fix.