search

ljleb / sd-webui-freeu

a1111 implementation of https://github.com/ChenyangSi/FreeU
MIT License
301 stars 16 forks source link

Make compatible with TensorRT extension #36

Open michael-imbeault opened 11 months ago

michael-imbeault commented 11 months ago

TensorRT is also hijacking unet, and the freeU extension has no effect with TensorRT enabled. Is there a way for you to make it compatible? Also, any plans to update to freeU v2?

michael-imbeault commented 11 months ago

See https://github.com/NVIDIA/Stable-Diffusion-WebUI-TensorRT

ljleb commented 11 months ago

I started working on v2 1 hour ago, will push it soon. Once I'm done with V2 I'll look into TRT

michael-imbeault commented 10 months ago

Can confirm v2 is working fine, thanks for the quick update - I'm following the issue you just opened in TensorRT, let's hope it's possible, the freeU improvements are good enough that I'm not using TensorRT at the moment - I'd rather have more quality than double speed

ljleb commented 10 months ago

Just a note, the current default presets have different performances depending on which version you are using. The authors of FreeU have updated their readme with new default values. I'm waiting for them to pin the values before updating the default presets. The default presets could be different depending on the active version in the extension.

For example, for the new SD1.4 preset, the only difference is that instead of backbone scale 1 = 1.2, it's 1.3. This actually has a major performance impact for V2.