search

ljleb / sd-webui-neutral-prompt

Collision-free AND keywords for a1111 webui!
MIT License
187 stars 13 forks source link

Greek Phi character in image metadata causes civitai to fail to process metadata #18

Closed lendrick closed 1 year ago

lendrick commented 1 year ago

I went into the code and changed it to "phi" and the issue went away. I'm running vladmandic, but someone also reported that it breaks automatic1111's ability to push image metadata to the text2img page.

ljleb commented 1 year ago

The webui is currently using the greek letter in their implementation PR as you can see here: https://github.com/AUTOMATIC1111/stable-diffusion-webui/pull/10555/files#diff-dfbe860dd55cebe453f0a354a58a7e6f99f27b4ce640070702e9738868e65298R333

My intent was to use the same value as the webui so that migrating would be straightforward. If you have an idea that also makes metadata work with future versions of the webui, I'm open to suggestions.

Unless the webui changes the copy_paste_param name, the issue may have to be resolved on civitai's end if possible. Otherwise, it may have to be reported on the webui PR as well so that we can keep the param name in sync.

ljleb commented 1 year ago

As the PR in auto1111 hasn't been updated in 2 weeks, I will introduce a fix for this. A bit annoying but when a1111 merges to main, to get old prompts to work, in the state of the PR right now, you will need to have this extension installed and active.

The story will be different if a1111 tests for the paste field used in this extension.