ljleb / sd-webui-neutral-prompt

Collision-free AND keywords for a1111 webui!
MIT License
187 stars 13 forks source link

`CFG rescale` only works on first generation #43

Closed catboxanon closed 1 year ago

catboxanon commented 1 year ago

Title. Upon loading the webui, the only time CFG rescale works is on the very first generation of an image. All generations that follow ignore the parameter. Using a debugger I can see it never reaches this line on those subsequent generations. Not sure what the cause is.

This is with version 1.6.0 of the webui. I haven't tested with all other extensions disabled yet but I don't believe I have any that would interfere with this.


While you're here, I believe this also is no longer necessary in the readme. https://github.com/ljleb/sd-webui-neutral-prompt#known-issues

ljleb commented 1 year ago

Thanks, I'll look into it. As the code is hard patched, I don't see how this happens. Maybe it depends on the sampler?

You're right for the incompatibility. I did update the code to make plms, unipc and ddim to work in 1.6 and still fail in 1.5.x or earlier, overlooked the readme.

ljleb commented 1 year ago

Unfortunately, I'm unable to reproduce this with these extensions enabled (webui==1.6.0):

If you have any of these extensions enabled, they are probably not responsible for the bad interaction.

ljleb commented 1 year ago

If you use specific generation parameters that cause this, it would help me narrow it down.

catboxanon commented 1 year ago

Ah shoot, I figured it out after I disabled all extensions (it persisted at this point), and then looked through the scripts I had in the scripts folder. I had some script I added at some point that modifies the sampler function and that intefered with this extension. Sorry for the trouble.