Closed wbclark closed 11 months ago
Why does adetailer rely on script filenames without a namespace? This is bound to create issues and will not scale long term. I don't mind merging this but it won't solve the problem at its root.
Why does adetailer rely on script filenames without a namespace? This is bound to create issues and will not scale long term. I don't mind merging this but it won't solve the problem at its root.
Hmmm, this is what adetailer is doing to filter scripts.
And from this, it looks like titles would work as long as they are defined.
Would you like me to raise an issue in adetailer about it?
In any case, changing the filename of the script makes sense because ui-config.json will put the controls under a custom namespace when you do, which would reduce the chances of ui settings collision (even though here the chances are already pretty low because this extension has like 3 controls)
You can open an issue if you want. Although I may be missing a bit of context as to why they are using script filenames, I believe it may be appropriate to use script titles instead.
!adetailer allows specifying additional scripts that run with it, but it does so by filename
this change makes it easier to enable sd-webui-neutral-prompt with !adetailer, and avoids potential collision with other extension scripts