search

ljlm0402 / typescript-express-starter

📘 Quick and Easy TypeScript Express Starter
http://npm.im/typescript-express-starter
MIT License
2.73k stars 420 forks source link

Create a new template MikroOrm #149

Closed ArturV93 closed 2 years ago

ArturV93 commented 2 years ago

Motivation (새로운 기능 설명)

Create a new template MikroOrm https://github.com/mikro-orm/mikro-orm

Proposed Solution (기능을 통해 얻고자 하는 솔루션)

Alternatives (제안 된 솔루션이 더 나은 이유)

Additional Context (추가 사항)

ljlm0402 commented 2 years ago

@ArturV93

Thank you for the good suggestion.

After reviewing the library, I will try to reflect it.

tamzidkarim commented 2 years ago

@ljlm0402 Hey I checked the dev branch, there was no mikro-orm template, so I was wondering did you start working on this template? If not then I have the template ready, I was working on it for quite some time.

ljlm0402 commented 2 years ago

@tamzidkarim

Hello. I am still in the preparation steps yet. If you have helped to make a template, I sincerely thank you.

tamzidkarim commented 2 years ago

@ljlm0402 hey is there any guideline or rules for contributing and making a pr? If there is could you share it to me? I would like to make a pr for this issue.

ljlm0402 commented 2 years ago

@tamzidkarim

Separate guidelines or rules do not exist. For the basic structure, refer to the DEFALUT template.

If you put a pull request, we will feedback to Code Review. thank you.

https://github.com/ljlm0402/typescript-express-starter/pull/69/files

ljlm0402 commented 2 years ago

@tamzidkarim

hello.

I wonder if there is a contribution to the issue. Currently, the contribution doctor has not temporarily developing development.

That is all.

tamzidkarim commented 2 years ago

@ljlm0402 hello I'm ready to make a pr.

tamzidkarim commented 2 years ago

@ljlm0402 Hey let me know if the PR looks okay.