gadget-man
commented
9 months ago This is being addressed as part of an upcoming PR. The strategy is as follows:
- The first event that meets the camera / zone / label should always be processed, no matter the top score.
- After the first processing, a tag is set for that event_id to flag that it's currently being processed by adding the event_id to the
CURRENT_EVENTSarray. - For the next
updateevent, if Frigate+ is set, the code checkssnapshot.attributes.score- if the before score is greater than the after, the best plate has already been submitted so it skips processing. - If Frigate is not set, it does the same, but based on the
top_scoredata. - When the event is tagged with type
end, the flag is cleared, and the final event is processed just to give the engine one last chance to recognise the plate.
The above strategy deals with a situation where there may be multiple events being processed concurrently - the CURRENT_EVENTS array will be populated with any events currently being processed, and they will be cleared once each particular event ends.
kyle4269
I think there's an issue with the way the script currently checks the top_score, here: https://github.com/ljmerza/frigate_plate_recognizer/blob/1782e4638b35a2291fe141bf809551d3f6b0e0fa/index.py#L211
I've noticed several events that never get passed to plate_recognizer. This happens when the top_score if flagged by Frigate BEFORE the object enters a zone being monitored by frigate_plate_recognizer. In my situation, I detect cars driving down a road, but only want plate detection when they pull into my drive. Sometimes, the best score from Frigate will be as the car slows down to turn into the drive. The implication of this is when frigate_plate_recognizer gets the first MQTT message that passes the first few
check_invalid_eventtests (matching zone, matching camera), frigate is already reporting the top_score, and so the very first valid mqtt event then fails thetop_scoretest.I hadn't noticed this before because in 1.7.X, configurations with
frigate_plusskipped this test.I think there should be an additional test so that, even if
before_data['top_score'] == after_data['top_score'], if it's the first time this event_id has been processed, it should still be passed toget_plate. I'm not sure how best to handle this, otherwise I'd have prosed a PR!