search

ljmerza / ha-our-groceries

Our Groceries Integration for Home Assistant
MIT License
38 stars 8 forks source link

Integration not working after updating HA to 2021.9.4 #23

Closed jampez77 closed 3 years ago

jampez77 commented 3 years ago

Version of the custom_component

1.3.9

Configuration

ourgroceries:
   username: !secret jamie_email
   password: !secret our_groceries_password

Describe the bug

Intergration isnt working after updating the 2021.9.4

Debug log


Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/setup.py", line 255, in _async_setup_component
    result = await task
  File "/config/custom_components/ourgroceries/__init__.py", line 66, in async_setup
    await og.login()
  File "/usr/local/lib/python3.9/site-packages/ourgroceries/__init__.py", line 80, in login
    await self._get_team_id()
  File "/usr/local/lib/python3.9/site-packages/ourgroceries/__init__.py", line 110, in _get_team_id
    self._category_id = re.findall(REGEX_CATEGORY_ID, responseText)[0]
IndexError: list index out of range
andreasbrett commented 3 years ago

Same here

163Albert commented 3 years ago

Ditto, same error message.

nathan-curtis commented 3 years ago

Ditto, same error message.

Ditto the report - same error. I was on 8.8 before upgrade. Although, I'm on 9.2 and have been since the weekend. I'm currently very active in my install, as I'm currently migrating from another system. I don't remember the error popping immediately after my upgrade to 9.2. It seemed 'new' to me tonight - thus why I came here to report it.

rpitera commented 3 years ago

Same issue and error message. Best of my memory it started on 2021.9.3 for me.

sevorl commented 3 years ago

I can confirm, this does not work in 2021.9.5 I updated from 2021.8.x, so I don't know if this used to work in earlier versions of 2021.9.x

papst01 commented 3 years ago

For ne it looks independent from the last HA updates. I only restarted Home Assistent and ourgroceries stopped working. I'm running core-2021.8.8. Error message is the same like the OP. So if the groceries component got no update then ourgroceries itself must have changed anything preventing the login.

andreasbrett commented 3 years ago

This is an issue with the login that changed on the server side of OurGroceries. See the used python libary and corresponding issue over there: https://github.com/ljmerza/py-our-groceries/issues/13

Once that is fixed, this HA integration will work again.

rpitera commented 3 years ago

Just want to keep this alive and stave off the stale bot. :)

davidwelsman commented 3 years ago

OurGroceries Support advises (not unreasonable - though the word 'fishing' is dark) "Home Assistant was fishing through our code to get information about lists. We can't keep our code unchanged forever, sometimes we want to make improvements. So there's nothing for us to "fix" here -- whoever wrote the Home Assistant code needs to update it, but also be aware that it'll keep breaking as long as they depend on undocumented parts of our code "

andreasbrett commented 3 years ago

Basic answer by a service provider that does not offer a public API and therefore third party code needs to scrape their web content. Unfortunately @ljmerza is not responding. The bug is fixed already and just needs to be merged.

ljmerza commented 3 years ago

Sorry I never got the notification for this issue until someone tagged me. Will look at today

andreasbrett commented 3 years ago

@ljmerza Thank you, that's good news. This is linked to https://github.com/ljmerza/py-our-groceries/issues/13 and https://github.com/ljmerza/py-our-groceries/pull/14

rpitera commented 3 years ago

Sorry I never got the notification for this issue until someone tagged me. Will look at today

Good to know for the future! ; ) Thanks as always.

ljmerza commented 3 years ago

fixed in v1.3.10

163Albert commented 3 years ago

Working well again. A huge thank you.

andreasbrett commented 3 years ago

@ljmerza could you please release 1.3.10? It's currently just a tag and latest_release still points to 1.3.9. HACS doesn't show an update to 1.3.10.

Thank you

Sep 27, 2021 06:29:37 163Albert @.***>:

Working well again. A huge thank you.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub[https://github.com/ljmerza/ha-our-groceries/issues/23#issuecomment-927521287], or unsubscribe[https://github.com/notifications/unsubscribe-auth/ABSN4E6WTMWICNL27KBPME3UD7XK5ANCNFSM5DU5WYUA]. Triage notifications on the go with GitHub Mobile for iOS[https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675] or Android[https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub]. [data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAD8AAAA/CAYAAABXXxDfAAAAAXNSR0IArs4c6QAAAARzQklUCAgICHwIZIgAAAAmSURBVGiB7cEBDQAAAMKg909tDwcUAAAAAAAAAAAAAAAAAAAAJwY+QwABivJx1AAAAABJRU5ErkJggg==###24x24:true###][Verfolgungsbild][https://github.com/notifications/beacon/ABSN4E6L4BCUE2E2LW2PZNDUD7XK5A5CNFSM5DU5WYUKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOG5ENUBY.gif]

rpitera commented 3 years ago

could you please release 1.3.10? It's currently just a tag and latest_release still points to 1.3.9.

OK, so it's not just me... I thought maybe there was an upstream dep that wasn't ready yet because I tried doing it manually and while the error went away, I didn't get a sensor. Hopefully I just installed it wrong or something and HACS install will solve this.

jampez77 commented 3 years ago

could you please release 1.3.10? It's currently just a tag and latest_release still points to 1.3.9. HACS doesn't show an update to 1.3.10.

I second this as an issue! Still seeing 1.3.9 as the latest.

davidwelsman commented 3 years ago

As an interim measure I copied and extracted the v1.3.10 zip file, and copied the contents of Our Groceries folder into the same named folder found in Config/Customer_Components. It works....

rpitera commented 3 years ago

When I did that, the error notification went away, but I didn't get an our groceries sensor. Been using HA since a few months after it's initial release, so I'm experienced with manual install method. I figured that possibly the upstream library wasn't released yet, but apparently this isn't the case if it's working for you. 😕

rpitera commented 3 years ago

BTW, @ljmerza - I don't know why it didn't work for me when I installed it manually, but my HACS update solved my issues after a reboot. Maybe I needed another reboot or two to get the dependency filled? Anyways, I thought I would add that. Thanks again!