search

ljmerza / light-entity-card

Control any light or switch entity
MIT License
233 stars 41 forks source link

group:true still renders a drop-shadow #35

Closed denilsonsa closed 4 years ago

denilsonsa commented 4 years ago

The group: true seems to change the header size but not much else. The light-entity-card is still rendered with extra whitespace and drop-shadow.

Screenshot demonstrating the bug.

type: entities
title: Bug in light-entity-card
entities:
  - entity: light.bath_color
  - group: true
    color_wheel: true  # Unused
    persist_features: true
    color_picker: false
    show_slider_percent: true
    full_width_sliders: true
    entity: light.bath_color
    type: 'custom:light-entity-card'
ljmerza commented 4 years ago

group: true is for group entities, looks like light.bath_color is just one entity?

schester44 commented 4 years ago

This was confusing to me as well. I was under the impression that group: true made it so this card could be used in a list of entities - but it doesn't look right with the shadow. An option to remove the shadow would be a nice to have.

denilsonsa commented 4 years ago

I had the same understanding as @schester44. Also because another custom card also has a group boolean option that allows using it inside the entities card: https://github.com/kalkih/mini-media-player#card-options

ljmerza commented 4 years ago

ive renamed the option in v4 to make it clearer what the option does

denilsonsa commented 4 years ago

For the record, for anyone else following this issue: b4eaba3cae9a7488aeb8d7e399df9716c0a1cca6 (and 44bc3fe28b60e3ca5c0b0d1a08bb8c2aed551e8d) replaced group with shorten_cards and consolidate_entities.

ljmerza commented 4 years ago

added child_card option that will remove padding and box shadow in v4.2.0