search

ljmerza / light-entity-card

Control any light or switch entity
MIT License
228 stars 41 forks source link

2022.3.X Breaks dropdown #84

Closed regevbr closed 2 years ago

regevbr commented 2 years ago

You are using paper-menu-button and paper-listbox with the assumption Home Assistant will load these elements.

In 2022.3 these elements are no longer part of Home Assistant, so this will no longer work.

see https://github.com/kalkih/mini-media-player/issues/606 for reference

image

SmarterHomeLife commented 2 years ago

Same for me, breaks the dropdown completely so options aren't clickable even when shown.

Psytoshgen commented 2 years ago

+1 got this issue about week...

antro31 commented 2 years ago

+1, same for me

niclasniedermaier commented 2 years ago

+1

compujunk commented 2 years ago

+1

ljmerza commented 2 years ago

looks like id have to do a bit of work here to get this working again. Unfortunely, I dont have the time right now to look into this but will look into any PRs anyone is able to add.

regevbr commented 2 years ago

looks like id have to do a bit of work here to get this working again. Unfortunely, I dont have the time right now to look into this but will look into any PRs anyone is able to add.

Done, To use the fix until it is released, follow the steps I made here

habuild commented 2 years ago

Thanks for the fix @regevbr .

Very tiny issue with the fix. The effects list is wider than the card when using it in a horizontal stack with two cards on android Home assistant app(and android chrome browser).

horizontal stack single card active effects list on horizontal stack 1

horizontal stack double card active effects list on horizontal stack 2

unstacked card android app effects list on horizontal stack 3 no stack

horizontal stack desktop chrome browser effects list on horizontal stack 4 desktop chrome

regevbr commented 2 years ago

Css is out of the scope of my expertise, I will leave it to the maintainer...

dashdrum commented 2 years ago

looks like id have to do a bit of work here to get this working again. Unfortunely, I dont have the time right now to look into this but will look into any PRs anyone is able to add.

Done, To use the fix until it is released, follow the steps I made here

FYI, this fix works for me when using Chrome, but not in Firefox, where the effects dropdown looks the same as the unfixed example back at the top of the thread.

Thanks for looking into this!

jsiemek commented 2 years ago

For me works OK also in Firefox. Did you clean FF cache?

regevbr commented 2 years ago

@dashdrum I just tried it on my Firefox and it works well. Indeed when you open the menu it can cause an "expansion" of the card (also in Chrome) which I mentioned in the PR and I don't know how to fix, and I will leave that for the maintiner. But unlike the issue, the buttons are still useable and the menu is not stuck in open state. Can you please verify for me that this is indeed the behaviour you are experiencing?

ljmerza commented 2 years ago

should be fixed in v5.0.0

bistek22 commented 2 years ago

It still does not work HA v2022.3.5 Light v5.0.0

Cache clear Firefox and Android

Firefox:

Zrzut ekranu 2022-03-16 225801

Apps HA Android:

Screenshot_20220316-225348_Home Assistant

regevbr commented 2 years ago

The first pictures are not related to this issue. About the app it seems that it was not refreshed yet as it seems like the old ui before the update

dashdrum commented 2 years ago

@dashdrum I just tried it on my Firefox and it works well. Indeed when you open the menu it can cause an "expansion" of the card (also in Chrome) which I mentioned in the PR and I don't know how to fix, and I will leave that for the maintiner. But unlike the issue, the buttons are still useable and the menu is not stuck in open state. Can you please verify for me that this is indeed the behaviour you are experiencing?

I can confirm that it does indeed work in Firefox. Sorry for the confusion.