search

ljramones / trips

A stellar cartography system
Apache License 2.0
15 stars 2 forks source link

Error plotting if data set not loaded and spelling in the title bar of the dialog box #309

Closed celebrith closed 3 years ago

celebrith commented 3 years ago
**Describe the bug** When you start the application and click on "Plot Stars" without selecting an active data set, the program pulls up a dialog box titled "Choice Data set to display". That should say "Choose data set to display". And, after clicking OK (on the 150LY data set, although I don't think that matters), I get the Astrographic data view error "Error. No Astrographic data was loaded". This works fine if you select a data set first and then plot, which leads me to believe that the "Choose data set to display dialog is not actually calling the "Select active dataset" routine. Error trace: 2021-04-03 21:09:23.152 INFO 26316 --- [lication Thread] c.teamgannon.trips.routing.RoutingPanel : adding routes 2021-04-03 21:09:23.465 INFO 26316 --- [lication Thread] c.t.t.j.r.impl.StarObjectRepositoryImpl : created the predicates 2021-04-03 21:09:24.341 INFO 26316 --- [lication Thread] c.t.t.j.r.impl.StarObjectRepositoryImpl : number of records found=0 2021-04-03 21:09:24.370 INFO 26316 --- [lication Thread] c.t.t.service.DatabaseManagementService : New DB Query returns 0 stars 2021-04-03 21:09:24.380 INFO 26316 --- [lication Thread] c.t.t.service.DatabaseManagementService : Filtered by distance Query returns 0 stars 2021-04-03 21:09:24.381 INFO 26316 --- [lication Thread] c.teamgannon.trips.graphics.PlotManager : DB Query returns 0 stars 2021-04-03 21:09:24.518 INFO 26316 --- [lication Thread] com.teamgannon.trips.routing.RouteCell : show route:Route: 1: Route Sol to 85 Pegasi Aa, path 2 has 2 segments 2021-04-03 21:09:24.524 INFO 26316 --- [lication Thread] com.teamgannon.trips.routing.RouteCell : show route:Route: 1: Route Sol to 85 Pegasi Aa, path 2 has 2 segments 2021-04-03 21:09:24.527 INFO 26316 --- [lication Thread] com.teamgannon.trips.routing.RouteCell : show route:Route: 2: Route Sol to 15 Sagittae A, path 3 has 2 segments 2021-04-03 21:09:24.530 INFO 26316 --- [lication Thread] com.teamgannon.trips.routing.RouteCell : show route:Route: 3: Route Sol to 15 Sagittae A, path 5 has 3 segments 2021-04-03 21:10:26.633 ERROR 26316 --- [lication Thread] c.teamgannon.trips.support.AlertFactory : No Astrographic data was loaded **TRIPS version** - [ ] 0.52 - [ ] 0.53 - [ ] 0.54 - [ ] 0.55 - [X] 0.6.7 **Desktop (please complete the following information):** - [ ] IOS - [ ] Windows 10 - [ ] Windows Vista, 7 or 8 - [ ] Windows XP - [ ] Linux (add distribution and version to this line) - [X] macOS **Additional info ** Add any other context about the problem here.
celebrith commented 3 years ago

This is in two places.
PlotManager.java line 99 (in public void showPlot - I assume this is the one being used here) MainPane.java line 1653(in private void showTableData) We should change both to "Choose data set to display"

ljramones commented 3 years ago

fixed

The second item is an old bug that I have currently fixed in the working version that will be released