search

ljubobratovicrelja / ffmpeg-d

D port of the FFmpeg C headers
16 stars 9 forks source link

fix issue 13 #14

Closed timotheecour closed 6 years ago

timotheecour commented 6 years ago

fix https://github.com/ljubobratovicrelja/ffmpeg-d/issues/13

ljubobratovicrelja commented 6 years ago

Thank you @timotheecour! @complistic-gaff this fix seems to be affecting all 3.x branches, so should probably be merged in 3.0 and 3.1 branches, as well as in master, right?

DavidBennettPIO commented 6 years ago

I haven't had time to look into this properly yet, but it looks to be related to a regression/improvement on 2.078.2? https://issues.dlang.org/show_bug.cgi?id=18385

I would have thought it would effect the 2.8 branch also?

In any case the workaround seems simple enough.

I think a C int is 4 bytes (same as D) in all the platforms/compilers we care about?

ljubobratovicrelja commented 6 years ago

Awesome, tnx @complistic-gaff! OK, merging this right now into master, and will release a patch for 3.1, since master is in sync with that branch. I'll try and merge this into version branches on weekend, and make 2.8 and 3.0 releases.