ljunkie / rarflix

Plex Roku Channel - original source from https://github.com/plexinc/roku-client-public
MIT License
117 stars 45 forks source link

Add Localization / Multilanguages #225

Closed ghost closed 2 years ago

ghost commented 10 years ago

No changes for English version French version not finished (just need to complete translating the xml file) but it's a hell of a work ;)

Can be easily done for German and Spanish as well.

ljunkie commented 10 years ago

I am making some major changes to DEV. We will see what sort of impact this has on this pull. As of right now, it's not possible since dev is in major flux. I will look into this after DEV has been pushed to test which I hope is relatively soon.

ljunkie commented 10 years ago

This is pretty awesome though and it is a lot of work.

ghost commented 10 years ago

Thanks. You're doing a great job (for both rarflix and plexwatch).

ghost commented 10 years ago

Any chance this gets merged to the master release?

ljunkie commented 10 years ago

Now that all is finalized, I can take a look. A lot was changed so this pull request is no longer valid. I'll let you know what my thoughts are in the next couple days.

ghost commented 10 years ago

Hi, If this doesn't work out, let me know a day when you will not work on Rarflix so I can do it on the master branch again.

ghost commented 10 years ago

Any good news? :)

ljunkie commented 10 years ago

I'm on vacation until the 26th, so feel free to work in it now. I do have some concern on upkeep, additions, modifications and file size (due to gen1 limits). So this still might have to be a separate branch and version pushed to the Roku.

ghost commented 10 years ago

Hi,

Maintaining the solution should not be too complicated. You would only have to :

I will handle the translation via the xml file and getlocalization.com.

Concerning the size limit, this should not be too heavy but you probably know more than me on that subject.