search

ljvmiranda921 / seagull

A Python Library for Conway's Game of Life
https://pyseagull.readthedocs.io/en/latest/index.html#
MIT License
175 stars 28 forks source link

Ensure that board.state will never change #20

Closed ljvmiranda921 closed 5 years ago

ljvmiranda921 commented 5 years ago

This commit interally copies the board state on the simulator and updates that. I think it's better that way (rather than updating the board inplace) so that there will be no unexpected behaviour during the runs

Signed-off-by: Lester James V. Miranda ljvmiranda@gmail.com

codecov[bot] commented 5 years ago

Codecov Report

Merging #20 into master will increase coverage by 0.03%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #20      +/-   ##
==========================================
+ Coverage   97.43%   97.46%   +0.03%     
==========================================
  Files          13       13              
  Lines         234      237       +3     
==========================================
+ Hits          228      231       +3     
  Misses          6        6
Impacted Files Coverage Δ
seagull/simulator.py 93.87% <100%> (+0.39%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 11b071f...9ab15cd. Read the comment docs.