search

ljvmiranda921 / seagull

A Python Library for Conway's Game of Life
https://pyseagull.readthedocs.io/en/latest/index.html#
MIT License
174 stars 30 forks source link

Adding RLE support, fix #45 ? #46

Closed eugenpt closed 4 years ago

eugenpt commented 4 years ago

Added RLE parser to lifeforms/wiki.py, +some refactoring

codecov[bot] commented 4 years ago

Codecov Report

Merging #46 into master will decrease coverage by 1.56%. The diff coverage is 88.60%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #46      +/-   ##
==========================================
- Coverage   98.13%   96.56%   -1.57%     
==========================================
  Files          13       13              
  Lines         322      379      +57     
==========================================
+ Hits          316      366      +50     
- Misses          6       13       +7
Impacted Files Coverage Δ
seagull/lifeforms/wiki.py 91.89% <88.60%> (-4.41%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d36cda9...b151f4c. Read the comment docs.

eugenpt commented 4 years ago

Sorry, it seems I was not successful in updating my fork (since so many commits are listed in this PR..). Or maybe the issue is that I've started to work on RLE in a separate branch before previous PR was approved and merged

ljvmiranda921 commented 4 years ago

Sure it's fine! Sorry won't be able to check this until Sunday (or the next weekend, not this week)! Will be on vacation leave for a bit to recharge! Will find a timeto read through this and add my comments!

eugenpt commented 4 years ago

Have a nice vacation !

ljvmiranda921 commented 4 years ago

Let me check the failing builds, mostly a dependencies thing!

ljvmiranda921 commented 4 years ago

This is now merged via #47 ! Thanks so much for this @eugenpt ! If you are interested, you can add documentation via Jupyter Notebooks like in here. This will then show up in our official documentation!