ahoward-cf commented 3 years ago

Added just the ChaCha as requested. I am happy to discuss how best to add Methuselashs prior to making a pull request. What would be the best place to discuss that?

codecov[bot] commented 3 years ago

Codecov Report

Merging #56 into master will decrease coverage by 0.14%. The diff coverage is 90.90%.

@@            Coverage Diff             @@
##           master      #56      +/-   ##
==========================================
- Coverage   96.61%   96.47%   -0.15%     
==========================================
  Files          13       13              
  Lines         414      425      +11     
==========================================
+ Hits          400      410      +10     
- Misses         14       15       +1

Impacted Files	Coverage Δ
seagull/lifeforms/__init__.py	`100.00% <ø> (ø)`
seagull/lifeforms/oscillators.py	`98.48% <90.90%> (-1.52%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ea98127...bf23a30. Read the comment docs.

ljvmiranda921 commented 3 years ago

Hi @ahoward-cf , sorry for the late reply. I'll review this PR this week! I think for the Methuselah one, you can open up another issue and we can discuss there!

ljvmiranda921 / seagull

Add ChaCha lifeform to oscillators and init #56

Codecov Report