search

ljvmiranda921 / seagull

A Python Library for Conway's Game of Life
https://pyseagull.readthedocs.io/en/latest/index.html#
MIT License
175 stars 28 forks source link

add methuselahs lifeforms #58

Closed ahoward-cf closed 3 years ago

ahoward-cf commented 3 years ago

Added the lifeforms to their own subclass and the init. They work locally. I think they should be able to check the board size and give a warning, as Methuselah lifeforms need a lot of room to stabilize. But I will wait for your input before trying something like that.

codecov[bot] commented 3 years ago

Codecov Report

Merging #58 into master will decrease coverage by 0.26%. The diff coverage is 91.30%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #58      +/-   ##
==========================================
- Coverage   96.47%   96.20%   -0.27%     
==========================================
  Files          13       14       +1     
  Lines         425      448      +23     
==========================================
+ Hits          410      431      +21     
- Misses         15       17       +2
Impacted Files Coverage Δ
seagull/lifeforms/methuselahs.py 90.90% <90.90%> (ø)
seagull/lifeforms/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2f88ded...6021031. Read the comment docs.

ljvmiranda921 commented 3 years ago

Hi @ahoward-cf , sorry, life got in the way so I wasn't able to get back on this. Reviewing in a while! Thanks for the patience!