search

lk-geimfari / mimesis-factory

Mimesis integration with factory_boy
https://pypi.org/project/mimesis-factory/
MIT License
51 stars 11 forks source link

Support for factory-boy 3+ #183

Closed michaeloliverx closed 3 years ago

michaeloliverx commented 4 years ago

Hey factory-boy have released version 3 but it looks like mimesis-factory depends on factory-boy (>=2.11,<3.0). Could we get this supported?

Much thanks for a great library!

sobolevn commented 4 years ago

PRs are welcome!

michaeloliverx commented 4 years ago

PRs are welcome!

I will try :)

michaeloliverx commented 4 years ago

This project clearly defines factory-boy = ">=2.11,<4.0" inside the pyproject.toml directory. But when I try to install with in my own project poetry I get:

[SolverProblemError]
Because mimesis-factory (1.1.0) depends on factory-boy (>=2.11,<3.0)
 and no versions of mimesis-factory match >1.1.0,<2.0.0, mimesis-factory (>=1.1.0,<2.0.0) requires factory-boy (>=2.11,<3.0).
So, because dacp depends on both mimesis-factory (^1.1.0) and factory-boy (^3), version solving failed.

Very strange because when I clone this repo and run poetry install it actually installs factory-boy v3.0.1

sobolevn commented 4 years ago

Checkout this line https://github.com/mimesis-lab/mimesis-factory/blob/1.1.0/pyproject.toml#L40

michaeloliverx commented 4 years ago

Checkout this line https://github.com/mimesis-lab/mimesis-factory/blob/1.1.0/pyproject.toml#L40

I was looking at the master branch (where it has been bumped). Looks like dependabot bumped the version in mimesis-lab/mimesis-factory/pull/178. How do we tag/initiate a release?

sobolevn commented 4 years ago

Manually only. I guess we can start with adding different factoryboy version to the CI, like here: https://github.com/sobolevn/django-split-settings/blob/master/.travis.yml#L9

michaeloliverx commented 4 years ago

Maybe I don't understand but I don't think it should effect anything since the current CI is still passing with the newest factory-boy version: https://travis-ci.com/github/mimesis-lab/mimesis-factory/jobs/376062661#L302

michaeloliverx commented 3 years ago

Can we trigger a release?

sobolevn commented 3 years ago

Yes, will do today!

sobolevn commented 3 years ago

Released 1.2.0