search

lk-geimfari / mimesis

Mimesis is a robust data generator for Python that can produce a wide range of fake data in multiple languages.
https://mimesis.name
MIT License
4.38k stars 326 forks source link

Add croatian locale #1467

Closed CerealKiller0807 closed 7 months ago

CerealKiller0807 commented 7 months ago

Hello,

Planned to create a pull request for the Croatian locale. I have the code ready in my local environment but get permission denied when trying to publish a new branch on this repository and create a new pull request.

Could you maybe help me with that?

lk-geimfari commented 7 months ago

Absolutely! You have to do these steps:

  1. Fork this repo and clone it to your local machine.
  2. cd mimesis && git checkout -b croatian-lang-support
  3. See https://github.com/lk-geimfari/mimesis/tree/master/mimesis/data/locale_template
  4. Commit your changes.
  5. Push your branch.
  6. Create Pull Request.
lk-geimfari commented 7 months ago

You can use cs locale as an example. I think these languages may be similar in term of structure.

lk-geimfari commented 7 months ago

@CerealKiller0807 Can you please tell me which code is used for vehacle registration in Croatia? Is it HR?

lk-geimfari commented 7 months ago

I've released version 13.0.0 with Locale.HR support. See https://github.com/lk-geimfari/mimesis/releases.

Thank you! It's great to have support for Croatian language.

CerealKiller0807 commented 7 months ago

To answer your question, registrations look like this HR-XXX-ZZ or HR-XXXX-ZZ

Where x is any number and ZZ is usually two characters short for the county :)