Move alias check before custom handler check

lk-geimfari / mimesis

Mimesis is a robust data generator for Python that can produce a wide range of fake data in multiple languages.

https://mimesis.name

MIT License

4.34k stars 326 forks source link

Move alias check before custom handler check #1515

Closed mheguy-flo closed 2 months ago

mheguy-flo commented 3 months ago

Move alias check before custom handler check.

Checklist

[X] I have read contributing guidelines
[X] I'm sure that I did not unrelated changes in this pull request
[X] I have created at least one test case for the changes I have made
[X] I have added myself to the CONTRIBUTORS.rst
[X] I have added my changes to the CHANGELOG.rst

Related issues

Closes #1514

codecov[bot] commented 3 months ago

Codecov Report

Merging #1515 (e8186c6) into master (c87af6d) will decrease coverage by 0.05%. The diff coverage is 100.00%.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #1515 +/- ## ========================================== - Coverage 57.08% 57.04% -0.05% ========================================== Files 60 60 Lines 2123 2123 ========================================== - Hits 1212 1211 -1 - Misses 911 912 +1 ```

mheguy-flo commented 3 months ago

Hmm.. do you have any guidance on why the coverage results changed? When running coverage locally, I don't see any change.

lk-geimfari commented 3 months ago

Hmm.. do you have any guidance on why the coverage results changed?

When running coverage locally, I don't see any change.

See https://github.com/lk-geimfari/mimesis/issues/1489