search

lk-geimfari / mimesis

Mimesis is a robust data generator for Python that can produce a wide range of fake data in multiple languages.
https://mimesis.name
MIT License
4.44k stars 336 forks source link

Arguments shadow builtin names #434

Closed sobolevn closed 6 years ago

sobolevn commented 6 years ago

After we have updated flake8-builtins we got new several new errors.

=================================== FAILURES ===================================
_________________________________ FLAKE8-check _________________________________
/home/travis/build/lk-geimfari/mimesis/mimesis/providers/business.py:47:5: A002 "copyright" is used as an argument and thus shadows a python builtin, consider renaming the argument
_________________________________ FLAKE8-check _________________________________
/home/travis/build/lk-geimfari/mimesis/mimesis/providers/cryptographic.py:37:5: A002 "hash" is used as an argument and thus shadows a python builtin, consider renaming the argument
/home/travis/build/lk-geimfari/mimesis/mimesis/providers/cryptographic.py:50:5: A002 "bytes" is used as an argument and thus shadows a python builtin, consider renaming the argument
lk-geimfari commented 6 years ago

@sobolevn If we will rename ones then we'll break API again. I don't know how to be.

sobolevn commented 6 years ago

Let's just ignore these errors. We can use # noqa: A002. http://flake8.pycqa.org/en/3.1.1/user/ignoring-errors.html#in-line-ignoring-errors