Closed sobolevn closed 5 years ago
Hi. As I understood it will be a another property zone: Optional[str] = None in constructor of BaseDataProvider. Also one more question: should it be a separate method for getting datetime with timezone or we need to add it to existent?
@northernwulf Hi! We already have method datetime() and all we need is just add support of parameter timezone
for it.
@sobolevn Correct me if I'm wrong.
@lk-geimfari it seems correct to me.
@lk-geimfari got it. Thanks
Hi! Just wondering if this enhancement has been added yet.
If not I'd like to give it a shot.
@e-vandenberg Hi! It still did not implement you can take it and implement!
Great. Just so I am not mistaken, would use of this timezone
param resemble the following?
>>> d = Datetime()
>>> d.datetime(timezone="America/Guadeloupe")
datetime.datetime(2003, 12, 18, 4, 53, 48, "America/Guadeloupe")
If not, what did you have in mind?
@sobolevn Please, share with your vision of this feature with @e-vandenberg
@e-vandenberg yeap, I had something similar in mind.
Implemented in #539
Currently I am unable to set timezone for cases like this:
But I would like to do something like:
I am not sure about the dependecies. Timezone support out-of-the-box is limited, we almost always use something like
pytz
.So, maybe in this case we will just implement the second case. Leaving timezone support optional. And only enabling passed in timezone.