search

lk-geimfari / mimesis

Mimesis is a robust data generator for Python that can produce a wide range of fake data in multiple languages.
https://mimesis.name
MIT License
4.38k stars 326 forks source link

Request for Indian locale addition #560

Closed ghost closed 5 years ago

ghost commented 5 years ago

Feature request

Thesis

Addition of Indian locate. I saw that mimesis welcomes people to add new locales. I am assuming that what I need to do is:

  1. Put locale data in https://github.com/lk-geimfari/mimesis/tree/master/mimesis/data following the given template. Not sure about the naming of it, either it would be en-IN or IN for Indian locale.
  2. Writing unit tests for the newly added locale.

Reasoning

I didn't find it and it will be useful for developers working with Indian users and need mimesis.

Questions

  1. Can I work on it. ( Not sure if it's already done )
  2. What docs/resources I should go through.
lk-geimfari commented 5 years ago

@kuroop Hi! We always welcome new locales. I'm not sure about data for India, because I don't know what is commonly the main language in India: English (en-in), Hindi (hi) or another language.

The main point: data must be valid for India.

lk-geimfari commented 5 years ago

@kuroop Answers:

Of course, you can! Read this: https://github.com/lk-geimfari/mimesis/blob/master/CONTRIBUTING.rst

ghost commented 5 years ago

Hi @lk-geimfari ,

As a country, India has lot of languages. What is the criteria to select ? popularity? I would say both locales should be included; so can we plan for both? I personally would want to start with English(en-in) and probably pick up Hindi(hi) later on.

Thanks for the link to that CONTRIBUTING doc. I will go through it.

lk-geimfari commented 5 years ago

@kuroop Which locale is much popular? Which one will be much useful for developers?

ghost commented 5 years ago

@lk-geimfari

en-in as Indian English is what all major universities and institutions use( who teach future developers). Also most websites provide a hi viewing interface but I have never seen them taking input and login details in that locale. So I doubt much usefulness of a test-data-generator for hi.

In my opinion en-in is a better choice if usefulness for developers is criteria.

lk-geimfari commented 5 years ago

Great, let's add only en-in.

lk-geimfari commented 5 years ago

There is no feedback, so I close this issue.