search

lkang2 / glmatrix

Automatically exported from code.google.com/p/glmatrix
0 stars 0 forks source link

Create seperated function for defined destination matrix and undifined #6

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago 
So we don't have to check it in code and can remove if(!dest)

Original issue reported on code.google.com by danielhe...@gmail.com on 5 Jun 2010 at 11:12

GoogleCodeExporter commented 8 years ago 
Not a bad idea. I'll see what I can do about getting this in there. (May be in 
the 
release after next)

Original comment by Tojiro@gmail.com on 5 Jun 2010 at 4:59

GoogleCodeExporter commented 8 years ago 
If we want persons to use this library then it would be best to keep all three 
function in there. something like:

mat4.multiply : function with code check
mat4.multiplynodest : function with no specific dest
mat4.multiplydest: function with dest defined

and keep a standard.

Also It could be handy to have another function for when dest === mat1.

mat4.multiplyref // I don't know a better way to describe it (similar to the 
way EWGL 
works)

But this will of course affect the size.

Original comment by jeroom832@gmail.com on 6 Jun 2010 at 8:18

GoogleCodeExporter commented 8 years ago 
Yeah, I am somewhat concerned about the size of the file, but my take on it is 
this: 
This one js file will almost certainly be downloaded to the client in the midst 
of 
textures, models, shaders, and much larger logic scripts. Unless we start 
pushing a meg 
in size I think that this will be one of the smaller resources a WebGL app will 
use.

What I'm really struggling with is the naming conventions. I've considered 
similar to 
what you list, but I'm not sure that I feel they convey the meaning well 
enough. I'll 
have to think about this one some more.

Original comment by Tojiro@gmail.com on 7 Jun 2010 at 3:17

GoogleCodeExporter commented 8 years ago 
Another comment:
Maybe we don't have to return a dest or a math in those new functions?

Original comment by danielhe...@gmail.com on 7 Jun 2010 at 9:34

GoogleCodeExporter commented 8 years ago 
it would be nice if we didn't have to but I think It should.

Original comment by jeroom832@gmail.com on 9 Jun 2010 at 5:46

GoogleCodeExporter commented 8 years ago

Original comment by Tojiro@gmail.com on 12 Jun 2010 at 5:19

GoogleCodeExporter commented 8 years ago 
We will be implementing this in https://github.com/feisty/math

If you have anymore suggestions do not hesitate to come and lodge an issue at 
https://github.com/feisty/math/issues

Original comment by pyrotech...@gmail.com on 15 Dec 2010 at 12:26