lkaric / nestjs-twilio

Injectable Twilio client for Nestjs.
https://www.npmjs.com/package/nestjs-twilio
MIT License
43 stars 11 forks source link

Nest 9.X support? #37

Closed ricbermo closed 2 years ago

ricbermo commented 2 years ago

Bug Report

Describe the Bug

This package cannot be installed on NestJS 9 projects

How to Reproduce

Steps to reproduce the behavior, please provide code snippets or a repository:

  1. try to install this package on a NestJS 9 project.

Expected Behavior

Tell me what should happen.

Error

Error resulted by the potential bug.

Your Environment

Error reproducing steps

Please explain how did your error ocurr, you can also leave gists, repos or any kind of codebase.

Additional Information

Any other information about the problem here.

ricbermo commented 2 years ago

Sorry I did not include all details, IMHO the title is pretty self explanatory 😅

Happy to help if needed!!

lkaric commented 2 years ago

@ricbermo, I'll be releasing a major version compatible with Nestjs 9.X in a couple of days. Thanks for showing interest in contributing!

thisisomar commented 2 years ago

Any updates on this? Happy to help if needed :)

lkaric commented 2 years ago

@thisisomar Just an Update, I'm cutting down the code and making it more maintainable by utilizing the configurable module builder. For the time being, I'm deprecating @InjectTwilio decorator and instead, it will be used as a service until I figure out how to provide the decorator as well. I'm publishing the new major version tonight.

Change in usage

@InjectTwilio()
private readonly twilioClient: TwilioClient

will change to

private readonly twilioService: TwilioService

If you're familiar with any approach that could provide us with a service approach and decorator, I'd be glad to hear it and/or look at any pr requests coming my way.

lkaric commented 2 years ago

@thisisomar @ricbermo Released v3.0.0 a couple of minutes ago, be sure to check out the docs because of the breaking changes. #38

lkaric commented 2 years ago

@ricbermo Closing the issue, considering it's resolved with v3