lkaric / nestjs-twilio

Injectable Twilio client for Nestjs.
https://www.npmjs.com/package/nestjs-twilio
MIT License
42 stars 10 forks source link

Twilio itself should be a peer dependency #6

Closed JacopoPatroclo closed 3 years ago

JacopoPatroclo commented 3 years ago

Feature Request

I want to be able to select a different version for Twilio client

Describe the Feature

I want to be able to select a different version of Twilio node client instead of the specific one that this wrapper enforce.

Describe the Solution you'd like

Add Twilio as a peer dependency instead of a direct dependency in package.json, maybe with something like this.

In package.json

....

"peerDependencies": {
    "twilio": "*"
  }

....

The star in there is because this package do not use some specific feature of twilio and should not enforce some specific version.

Additional Information

I use this article as a reference for when to use peer or not.

See for example TypeOrm Nest integration. In this case this package enforce a specific version for TypeOrm.

I will follow up this issue with a pull request if you guys don't have the time to look into it.