question on the cuda rasterizer

lkeab / gaussian-grouping

[ECCV'2024] Gaussian Grouping for open-world Anything reconstruction, segmentation and editing.

https://arxiv.org/abs/2312.00732

Apache License 2.0

500 stars 37 forks source link

question on the cuda rasterizer #18

Open kamwoh opened 5 months ago

kamwoh commented 5 months ago

https://github.com/lkeab/gaussian-grouping/blob/fd359422059ef61cce19db06f63e9f3e01156a84/submodules/diff-gaussian-rasterization/cuda_rasterizer/backward.cu#L455C2-L459C59

if (inside)
    for (int i = 0; i < C; i++)
    dL_dpixel[i] = dL_dpixels[i * H * W + pix_id];
    for (int i = 0; i < O; i++)
    dL_dpixel_obj[i] = dL_dpixels_objs[i * H * W + pix_id];

hi, for the code above, should the second for loop be enclosed by the if statement? if so, should we add curly brackets?

ymq2017 commented 5 months ago

Hi, thank you very much for that problem! Yes we need curly brackets here and I have corrected the code.