lkelly93 / scheduler

Schedules and runs foreign code sequentially.
MIT License
0 stars 1 forks source link

Refactor executes errors #16

Closed lkelly93 closed 4 years ago

lkelly93 commented 4 years ago

Added types_errors.go

executable.go

Test Files

All runner_XXXX.go files

runner_java.go

types.go

@joshua-sterner I am going to let you approve this merge because these changes are going to be mostly implemented by the server package. Let me know if you have any questions.

lkelly93 commented 4 years ago

@joshua-sterner The build failed because I changed the return type for Run() but is passing all my local tests. Let me see if I can fix that really quick. I don't have the server package pulled over into this branch yet.

joshua-sterner commented 4 years ago

@joshua-sterner do you want to combine RuntimeErrors and TimeLimitExceededErrors? I could see them as being one thing. What is easier from the server's perspective?

I think it makes sense for these to be separate, as we might want slightly different behavior in the frontend in response to these two error types.