lkelly93 / scheduler

Schedules and runs foreign code sequentially.

MIT License

0 stars 1 forks source link

Refactor executable tests for concurrent runs #18

Closed lkelly93 closed 4 years ago

lkelly93 commented 4 years ago

types.go

Added language string to the executableState struct.

executable.go

Remove FileNamePrefix from error output.
Now adding language to the executable's state struct.

All executable_long_tests.go/executable_test.go/file_handler_test.go

Refactored all these tests to use table driven tests for the majority of their tests.
- Refactored all tests to be run in parallel
These changes shaved 10% off of the current run time of the tests. Unfortunately our longest test takes about 15 seconds while almost all other tests finish in less than two seconds.

generic_methods_test.go

Deleted getNewExecutableForTesting
- This method was no longer needed in our current testing setup
Changed all error type checking functions into boolean functions to be used throughout.

All runner_XXX.go files

Removed setting the *FileSettings empty values to default values. This is now being done in Run() in the executable.go file.