search

lkerr / groundfish-MSE

Development of Robust Management Strategies for Northeast Groundfish Fisheries in a Changing Climate
MIT License
4 stars 2 forks source link

quota_price function does not match input data #303

Closed mle2718 closed 4 months ago

mle2718 commented 6 months ago

The quota price function passes in these variables https://github.com/lkerr/groundfish-MSE/blob/fa057973568ad4074b3f6d186f00003737785498/functions/economic/get_predict_quota_prices.R#L53-L57

I am reading in a quota price equation that contains "spatial" things. https://github.com/lkerr/groundfish-MSE/blob/fa057973568ad4074b3f6d186f00003737785498/preprocessing/economic/quota_price_coefs.R#L7-L8

But I am implicitly predicting at the spatial values=0 by not including them in the quota price function. Either

  1. Read in the non-spatial data -- adjust the data processing code to point to NS coefficients
  2. Adjust the quota price function to predict using the spatial variables.

It would be better to move the definitions of level_RHSnames and select_RHSnames out of this function and into set_om_parameters_global.R, next to where the choice equation variables are setup

mle2718 commented 4 months ago

I chose to do 1 -- read in the coefficients from the non-spatial model

addressed with a4a4f0232b8603292a6cd15cbc482b1827512b1c 00008b49da87b62a65f35df256f2b85a7e3796b9 958f6ded1dd94edd5c3e97524b618b0b7ff7807d 21b040ba24b65d33c314c8de5bb8ff239516c1cd