search

lkiesow / python-feedgen

Python module to generate ATOM feeds, RSS feeds and Podcasts.
https://feedgen.kiesow.be/
BSD 2-Clause "Simplified" License
726 stars 122 forks source link

Fix dc extension #12

Closed wltb closed 10 years ago

wltb commented 10 years ago

The dc extension empties feed entries because DcEntryExtension uses the extend_* methods of the base class, which is suited for the whole feed only. This patch implements the extend_rss method, and lets atom entries escape unchanged.

lkiesow commented 10 years ago

Thanks for the patch. I'll review and merge it in the next days.

wltb commented 10 years ago

OK. Short question: I made two additional changes, a small one to the file output (adding a pretty print parameter and passing the first argument directly to lxml, which accepts file names as well as file-like objects), and created a new extension for the content namespace.

Should I commit those in this pull request, or better wait?

lkiesow commented 10 years ago

I don't mind as long as you tell me what I should expect to be in the branch ;-)

wltb commented 10 years ago

Submitted the file output changes. I'll create another pull request for the content extension after this is merged or rejected.

lkiesow commented 10 years ago

@wltb, sorry for the long wait, I've finally managed to have a look at this.

shon commented 10 years ago

Hi @lkiesow , I faced the same issue today only to realize that it's fixed on github. Possible to release an update on pypi so that we can pull it. Thanks.