search

lkiesow / python-feedgen

Python module to generate ATOM feeds, RSS feeds and Podcasts.
https://feedgen.kiesow.be/
BSD 2-Clause "Simplified" License
723 stars 123 forks source link

Unit Tests: Temporary file handles need to be closed explicitly under… #56

Closed stbisplinghoff closed 7 years ago

stbisplinghoff commented 7 years ago

… Windows

Running the unit tests on Windows Python 3.6 x64 fails because the temporary files cannot be removed. The filehandle returned by mkstemp() is still in use and must be explicitly closed before file removal.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 93.068% when pulling f0c066af0f133437cd6f821bd106cef65af7ff10 on stbisplinghoff:winUnitTests into f6d11937b447f76c3b18af6f4decff280f7f2d58 on lkiesow:master.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 93.068% when pulling f0c066af0f133437cd6f821bd106cef65af7ff10 on stbisplinghoff:winUnitTests into f6d11937b447f76c3b18af6f4decff280f7f2d58 on lkiesow:master.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 93.068% when pulling f0c066af0f133437cd6f821bd106cef65af7ff10 on stbisplinghoff:winUnitTests into f6d11937b447f76c3b18af6f4decff280f7f2d58 on lkiesow:master.

lkiesow commented 7 years ago

Thanks for the patch. Looks good → merged