lkiesow / python-feedgen

Python module to generate ATOM feeds, RSS feeds and Podcasts.
https://feedgen.kiesow.be/
BSD 2-Clause "Simplified" License
723 stars 123 forks source link

add new media entry extension #58

Closed lrusak closed 6 years ago

lrusak commented 7 years ago

First off, thank you for the wonderful library. I needed to generate an atom feed for a project I am working on and this library fit the bill. It was missing the media tags I needed so I decided to add them.

This doesn't include all the media tags, it just includes the ones I need but it is a good start.

I don't really want to add more than this but maybe you'd like to include this as a good start to this extension (I didn't really want to do the complete implementation or write tests).

I followed this, http://www.rssboard.org/media-rss#media-content

lkiesow commented 7 years ago

Thaks for the patch. Can you please make it PEP8/flake8 compliant? See the failing tests.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-5.6%) to 87.427% when pulling ba5bbd2256ce4316cf7fb7040fcd6c870e5cd89c on lrusak:media-content into 9ac741ac0e25bfd75ecf97fd7e5383225085360b on lkiesow:master.

lrusak commented 7 years ago

I updated it. Anything else I can do?

JamesIves commented 7 years ago

Is this going to be merged at some point? Would be very useful.

netllama commented 7 years ago

Another vote to have this merged.

lkiesow commented 7 years ago

Finally found some time to do a proper review, sorry for letting you wait. I found some issues for which I wrote patches and pushed them into the branch media-content. Can you check if these changes are ok for you?

Still a lot of the Media RSS elements are not implemented. But that is something to expand for another time.

lkiesow commented 6 years ago

Just merged my modified version since there was no reply/complaint about it.

lrusak commented 6 years ago

Thanks! Apologies that I didn't have time to follow up!