search

lkiesow / python-feedgen

Python module to generate ATOM feeds, RSS feeds and Podcasts.
https://feedgen.kiesow.be/
BSD 2-Clause "Simplified" License
723 stars 123 forks source link

Extend geoms for geo #85

Closed om-henners closed 5 years ago

om-henners commented 5 years ago

Hi all,

I've added to the geo extension to include support for the rest of the simple feature specification (so to include lines, polygons, etc, but no GML). This includes a simple method to generate geometries from geometries that implement a __geo_interface__ (see https://gist.github.com/sgillies/2217756) if they are Point, LineString or Polygon.

The other major change is a reshuffle of the unit tests for extensions into their own submodule (rather than being in a single file). I did this to keep the file a bit cleaner when I wanted to extend the unit tests for the geo extension for the new changes I've made.

om-henners commented 5 years ago

Apologies for leaving it so long to get back to the errors! The Flake 8 errors (and the error in the Python2.7 side of the unit test) should have been resolved.

coveralls commented 5 years ago

Coverage Status

Coverage increased (+0.3%) to 93.675% when pulling 66f8bdb45ec6973efca3c712678a88a4ef020a2e on om-henners:extend_geoms_for_geo into 2beefb51266434de5293c1f1606b92bee7101f19 on lkiesow:master.

coveralls commented 5 years ago

Coverage Status

Coverage increased (+0.3%) to 93.675% when pulling 66f8bdb45ec6973efca3c712678a88a4ef020a2e on om-henners:extend_geoms_for_geo into 2beefb51266434de5293c1f1606b92bee7101f19 on lkiesow:master.

om-henners commented 5 years ago

That said it looks like there's an error as the latest version of lxml has dropped support for Python 3.4 as of the 27th of July (see https://lxml.de/4.4/changes-4.4.0.html)

One fix would be use environment markers in the requirements.txt file, but I'd be reluctant to mess with that without your permission!

lkiesow commented 5 years ago

I guess we can just bump the Python version for that. 3.4 is rather dated anyway. I'll take a look and hopefully merge this this week (sorry for the delay from me as well ;-)

lkiesow commented 5 years ago

I've updates the Travis build instructions. This patch builds fine now. Thanks for the patch. Merged.