Closed jmcvey3 closed 1 year ago
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
dolfyn/adp/clean.py | 3 | 4 | 75.0% | ||
dolfyn/binned.py | 1 | 2 | 50.0% | ||
dolfyn/io/rdi.py | 4 | 5 | 80.0% | ||
dolfyn/tests/test_shortcuts.py | 2 | 3 | 66.67% | ||
dolfyn/rotate/base.py | 15 | 17 | 88.24% | ||
dolfyn/tests/test_analysis.py | 43 | 46 | 93.48% | ||
dolfyn/velocity.py | 54 | 63 | 85.71% | ||
dolfyn/adv/turbulence.py | 9 | 29 | 31.03% | ||
dolfyn/adp/turbulence.py | 170 | 213 | 79.81% | ||
<!-- | Total: | 362 | 443 | 81.72% | --> |
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
dolfyn/binned.py | 1 | 86.83% | ||
dolfyn/tests/test_analysis.py | 1 | 89.91% | ||
dolfyn/velocity.py | 3 | 91.93% | ||
dolfyn/adv/turbulence.py | 4 | 80.85% | ||
dolfyn/io/rdi_defs.py | 6 | 90.77% | ||
dolfyn/io/rdi.py | 33 | 83.81% | ||
<!-- | Total: | 48 | --> |
Totals | |
---|---|
Change from base Build 4359628147: | -0.6% |
Covered Lines: | 5340 |
Relevant Lines: | 5991 |
I think this would be a good time/place to add a calc_tilt
function. i.e.: https://math.stackexchange.com/questions/2563622/vertical-inclination-from-pitch-and-roll
Adds an ADCP turbulence class (analogous to ADV turbulence class) containing calculations for Reynolds stress tensor from beam variances, doppler noise, TKE dissipation and production.
Needs verification and testing.