lkilcher / dolfyn

A library for oceanographic doppler instruments such as Acoustic Doppler Profilers (ADPs, ADCPs) and Acoustic Doppler Velocimeters (ADVs).
BSD 3-Clause "New" or "Revised" License
41 stars 25 forks source link

Update for CF/IOOS Conventions #118

Closed jmcvey3 closed 8 months ago

jmcvey3 commented 1 year ago

Fixes to dolfyn metadata to conform to CF/IOOS variable metadata conventions.

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 5545879432

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details


Changes Missing Coverage Covered Lines Changed/Added Lines %
dolfyn/io/nortek2_lib.py 9 10 90.0%
dolfyn/io/base.py 10 13 76.92%
dolfyn/tests/test_read_io.py 4 8 50.0%
dolfyn/io/nortek2.py 16 30 53.33%
<!-- Total: 53 75 70.67% -->
Files with Coverage Reduction New Missed Lines %
dolfyn/io/api.py 1 93.24%
dolfyn/tests/test_read_io.py 1 79.27%
dolfyn/io/nortek.py 2 90.52%
<!-- Total: 4 -->
Totals Coverage Status
Change from base Build 4757548436: -0.1%
Covered Lines: 5385
Relevant Lines: 6031

💛 - Coveralls
jmcvey3 commented 8 months ago

@lkilcher Realized you never hit the check so this can merge.