lkilcher / dolfyn

A library for oceanographic doppler instruments such as Acoustic Doppler Profilers (ADPs, ADCPs) and Acoustic Doppler Velocimeters (ADVs).
BSD 3-Clause "New" or "Revised" License
41 stars 25 forks source link

Fixes for Nortek Altimeter Measurements #125

Closed jmcvey3 closed 7 months ago

jmcvey3 commented 7 months ago

PR to resolve:

  1. Reader bugs discovered in Issue #122
  2. Corrections to altimeter variable names and metadata based on Nortek software data output
  3. Add AWAC altimeter measurements to reader

TODO

coveralls commented 7 months ago

Pull Request Test Coverage Report for Build 7188198204


Changes Missing Coverage Covered Lines Changed/Added Lines %
dolfyn/tests/test_read_adp.py 7 8 87.5%
dolfyn/io/nortek2.py 13 15 86.67%
dolfyn/io/nortek.py 2 49 4.08%
<!-- Total: 45 95 47.37% -->
Files with Coverage Reduction New Missed Lines %
dolfyn/io/nortek2_defs.py 1 95.95%
dolfyn/tests/test_read_adp.py 1 80.29%
<!-- Total: 2 -->
Totals Coverage Status
Change from base Build 7185583123: -0.7%
Covered Lines: 5413
Relevant Lines: 6107

💛 - Coveralls
jmcvey3 commented 7 months ago

@lkilcher Would like to merge PR #124 first, then this one. The reason for recreating all the Nortek ad2cp test files was because I changed the ID tag names in the "burst_config" attribute.