search

lkilcher / dolfyn

A library for oceanographic doppler instruments such as Acoustic Doppler Profilers (ADPs, ADCPs) and Acoustic Doppler Velocimeters (ADVs).
BSD 3-Clause "New" or "Revised" License
41 stars 25 forks source link

Various Updates #127

Closed jmcvey3 closed 2 months ago

jmcvey3 commented 5 months ago
  1. Add function to calculate TI with a given noise level
  2. Fixes bug where the provided noise level would not be subtracted from spectra
  3. Added ability to subtract noise from turbulence intensity and Doppler noise from dissipation rates
  4. Added ability to read dual profiling Nortek AD2CPs
coveralls commented 5 months ago

Pull Request Test Coverage Report for Build 8990137750

Details

Changes Missing Coverage Covered Lines Changed/Added Lines %
dolfyn/io/api.py 3 4 75.0%
dolfyn/tests/test_analysis.py 26 27 96.3%
dolfyn/tests/test_read_adp.py 4 5 80.0%
dolfyn/adv/turbulence.py 10 12 83.33%
dolfyn/io/base.py 62 64 96.88%
dolfyn/adp/turbulence.py 10 13 76.92%
dolfyn/io/nortek2.py 85 88 96.59%
dolfyn/velocity.py 26 30 86.67%
dolfyn/tools/psd.py 7 13 53.85%
dolfyn/io/nortek2_lib.py 26 36 72.22%
<!-- Total: 260 293 88.74% -->
Files with Coverage Reduction New Missed Lines %
dolfyn/io/nortek2.py 1 92.69%
dolfyn/tools/psd.py 1 84.8%
dolfyn/tests/test_read_adp.py 1 80.28%
dolfyn/adp/turbulence.py 3 82.65%
<!-- Total: 6 -->
Totals Coverage Status
Change from base Build 8177249776: 0.3%
Covered Lines: 5679
Relevant Lines: 6377
💛 - Coveralls
jmcvey3 commented 4 months ago

Looks good. The only thing I'd suggest is try to keep the test-coverage higher.

Yep I'm working on the test file for the dual profile additions