search

lkilcher / dolfyn

A library for oceanographic doppler instruments such as Acoustic Doppler Profilers (ADPs, ADCPs) and Acoustic Doppler Velocimeters (ADVs).
BSD 3-Clause "New" or "Revised" License
42 stars 25 forks source link

Dolfyn 1.3.0 doesn't support scipy 1.14.0 #129

Open asaunier-ifr opened 3 months ago

asaunier-ifr commented 3 months ago

Last version of scipy is incompatible with dolfyn 1.3.0. It is due to the use of scipy.integrate.cumtrapz which is not anymore present.

Is it planned to deliver a new version of Dolfyn in Pypi ?

Best regards

jmcvey3 commented 3 months ago

Hi @asaunier-ifr, future development of dolfyn is continuing in MHKiT. You can install that package with pip install mhkit and import using from mhkit import dolfyn. Some of the analysis functions have changed, but these should be recorded in the documentation or example notebooks in that package

asaunier-ifr commented 3 months ago

Hi @jmcvey3, thanks a lot for this info. I can see that mhkit is blocking scipy version 1.14.0 for now, but I suppose that limitation will be released as soon as all dependancies will be tested and compatible. Br

jmcvey3 commented 3 months ago

Yes, PR https://github.com/MHKiT-Software/MHKiT-Python/pull/333 will fix that.