lkilcher / dolfyn

A library for oceanographic doppler instruments such as Acoustic Doppler Profilers (ADPs, ADCPs) and Acoustic Doppler Velocimeters (ADVs).
BSD 3-Clause "New" or "Revised" License
43 stars 26 forks source link

Improper handling of declination in motion correction. #13

Closed lkilcher closed 7 years ago

lkilcher commented 7 years ago

The motion correction algorithms don't properly account for declination when calculating velacc (and AccelStable, and Accel). This is because these data items are computed separately, and before any others. This won't affect data where declination was not specified, but it means that velacc is in a different coordinate system (magnetic North) than the other variables such as vel and velrot (True North), when it is.

lkilcher commented 7 years ago

OK. This is fixed. Now to discover how much it messed with the data?! :(