search

lkilcher / dolfyn

A library for oceanographic doppler instruments such as Acoustic Doppler Profilers (ADPs, ADCPs) and Acoustic Doppler Velocimeters (ADVs).
BSD 3-Clause "New" or "Revised" License
43 stars 26 forks source link

Issue with read_nortek function #14

Closed Tkideau closed 5 years ago

Tkideau commented 7 years ago

Hello lklicher, I was planning to develop a Python script to read .vec file when I found your library : very useful ! Many thanks for developing it ! I began to use your _readnortek function and it works well on the majority of my .vec file but on some others, it throws this error : error I saw a similar issue was raised in the past and partially solved : https://github.com/lkilcher/dolfyn/issues/3 Unfortunately I can't provide you the .vec that are raising the error but the thing I can tell you is that data are generated in continuous mode. Thank you for your time, Tkideau

Tkideau commented 7 years ago

Hello lklicher, I noted another issue perhaps related to this one : when processing some .vec files, the while loop in the findnextid() method (line 966) turns into an infinite loop. Variable nowid alternate between values 0 and 165 but never go to 17 (which seems to be the typical termination condition). I observed the same in the case of "Reached the end of the file." issue. I'm thus thinking that the problem is around here (searchcode, _readid(), read() ...). Hope you will find a bit of time to look at this ! Regards, Tkideau

lkilcher commented 7 years ago

Hi and sorry for the slow response. It's extremely hard for me to debug these kinds of errors without the source file. If there is any way to share the data file with me I can assure you I won't share it with anyone else or use it for anything other than debugging. Otherwise, it's really not worth my time to try to guess what the problem is.

lkilcher commented 5 years ago

Closing this due to lack of: activity and data.