lkilcher / dolfyn

A library for oceanographic doppler instruments such as Acoustic Doppler Profilers (ADPs, ADCPs) and Acoustic Doppler Velocimeters (ADVs).
BSD 3-Clause "New" or "Revised" License
42 stars 25 forks source link

Use userdata.json files for ADPs #36

Closed lkilcher closed 5 years ago

lkilcher commented 5 years ago

Also, use declination in those files for inst2earth rotations.

This addresses #35 and #34.

lkilcher commented 5 years ago

How are we going to check that magnetic_var_deg is already included in the heading data? (i.e. we need to confirm the assumptions in 56fd046).

codecov[bot] commented 5 years ago

Codecov Report

Merging #36 into master will increase coverage by 0.39%. The diff coverage is 81.35%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #36      +/-   ##
==========================================
+ Coverage   43.97%   44.36%   +0.39%     
==========================================
  Files          61       60       -1     
  Lines        6986     7010      +24     
==========================================
+ Hits         3072     3110      +38     
+ Misses       3914     3900      -14
Impacted Files Coverage Δ
dolfyn/adp/clean.py 0% <ø> (ø) :arrow_up:
dolfyn/adv/motion.py 60.35% <0%> (-0.24%) :arrow_down:
dolfyn/adp/base.py 46% <0%> (+1.55%) :arrow_up:
dolfyn/rotate/signature.py 87.71% <100%> (ø) :arrow_up:
dolfyn/io/nortek2.py 82.66% <100%> (+0.23%) :arrow_up:
dolfyn/io/nortek.py 89.42% <100%> (+2.41%) :arrow_up:
dolfyn/rotate/rdi.py 88.23% <100%> (+7.38%) :arrow_up:
dolfyn/rotate/vector.py 82.72% <100%> (ø) :arrow_up:
dolfyn/tools/misc.py 60.13% <100%> (ø) :arrow_up:
dolfyn/io/rdi.py 68.24% <47.82%> (-0.77%) :arrow_down:
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 843a564...2857cd8. Read the comment docs.

codecov[bot] commented 5 years ago

Codecov Report

Merging #36 into master will increase coverage by 0.28%. The diff coverage is 76.58%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #36      +/-   ##
==========================================
+ Coverage   43.97%   44.25%   +0.28%     
==========================================
  Files          61       61              
  Lines        6986     7011      +25     
==========================================
+ Hits         3072     3103      +31     
+ Misses       3914     3908       -6
Impacted Files Coverage Δ
dolfyn/adp/clean.py 0% <ø> (ø) :arrow_up:
dolfyn/adv/motion.py 60.35% <0%> (-0.24%) :arrow_down:
dolfyn/adp/base.py 47.91% <0%> (+3.47%) :arrow_up:
dolfyn/rotate/signature.py 87.93% <100%> (+0.21%) :arrow_up:
dolfyn/io/nortek2.py 82.66% <100%> (+0.23%) :arrow_up:
dolfyn/io/nortek.py 89.42% <100%> (+2.41%) :arrow_up:
dolfyn/rotate/rdi.py 88.23% <100%> (+7.38%) :arrow_up:
dolfyn/rotate/base_nortek.py 100% <100%> (+6.89%) :arrow_up:
dolfyn/rotate/vector.py 82.88% <100%> (+0.15%) :arrow_up:
dolfyn/tools/misc.py 60.13% <100%> (ø) :arrow_up:
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 843a564...abba80d. Read the comment docs.

lkilcher commented 5 years ago

The travis builds had strange errors, but I'm sure we're good to go.

lkilcher commented 5 years ago

Resolved #34 and #35