Coordinate system of Motion Correction

lkilcher / dolfyn

A library for oceanographic doppler instruments such as Acoustic Doppler Profilers (ADPs, ADCPs) and Acoustic Doppler Velocimeters (ADVs).

BSD 3-Clause "New" or "Revised" License

42 stars 25 forks source link

Coordinate system of Motion Correction #41

Closed lkilcher closed 5 years ago

lkilcher commented 5 years ago

It seems that there is an inconsistency between correct_motion and CorrectMotion in that: the former explicitly requires the input object be in the inst coordinate system, but it is implicit for the latter. If the latter works on data in the 'earth' frame, is this creating errors because the angrt data is in earth frame?!

lkilcher commented 5 years ago

Resolved by 7c8c62a780ae310b1ffdf04592fa77f400b04334