lkilcher / dolfyn

A library for oceanographic doppler instruments such as Acoustic Doppler Profilers (ADPs, ADCPs) and Acoustic Doppler Velocimeters (ADVs).
BSD 3-Clause "New" or "Revised" License
42 stars 25 forks source link

Wrong Pitch/Roll/Heading out of DOLfYN #44

Closed lkilcher closed 5 years ago

lkilcher commented 5 years ago

It appears that p,r,h are calculated incorrectly in dolfyn.rotate.base.nortek_orient2euler. I think we need to take the inverse of omat before calculating?! How does this relate with euler2orient?

lkilcher commented 5 years ago

I believe this is resolved by #50. @mcfogarty please confirm.

lkilcher commented 5 years ago

I'm fairly sure this is closed by #50.