lkilcher / dolfyn

A library for oceanographic doppler instruments such as Acoustic Doppler Profilers (ADPs, ADCPs) and Acoustic Doppler Velocimeters (ADVs).
BSD 3-Clause "New" or "Revised" License
42 stars 25 forks source link

Upgrades to orientation info and declination handling #50

Closed lkilcher closed 5 years ago

lkilcher commented 5 years ago

Major changes highlighed in changelog.md, detailed changes to API documented in the docs.

lkilcher commented 5 years ago

Also, this replaces #46.

codecov[bot] commented 5 years ago

Codecov Report

Merging #50 into master will increase coverage by 0.69%. The diff coverage is 90.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #50      +/-   ##
==========================================
+ Coverage   44.47%   45.17%   +0.69%     
==========================================
  Files          60       61       +1     
  Lines        7020     7113      +93     
==========================================
+ Hits         3122     3213      +91     
- Misses       3898     3900       +2
Impacted Files Coverage Δ
dolfyn/adv/motion.py 61.04% <ø> (-0.23%) :arrow_down:
dolfyn/io/nortek.py 89.62% <100%> (+0.19%) :arrow_up:
dolfyn/test/test_rotate_adv.py 88.88% <100%> (+2.12%) :arrow_up:
dolfyn/rotate/rdi.py 90.47% <100%> (-0.23%) :arrow_down:
dolfyn/__init__.py 100% <100%> (ø) :arrow_up:
dolfyn/rotate/__init__.py 100% <100%> (ø) :arrow_up:
dolfyn/io/api.py 92.3% <100%> (ø) :arrow_up:
dolfyn/_version.py 76.47% <100%> (ø) :arrow_up:
dolfyn/rotate/signature.py 87.5% <50%> (-0.22%) :arrow_down:
dolfyn/test/test_rotate_adp.py 80.89% <83.33%> (+0.89%) :arrow_up:
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7c8c62a...1a43c66. Read the comment docs.

codecov[bot] commented 5 years ago

Codecov Report

Merging #50 into master will increase coverage by 0.72%. The diff coverage is 89.76%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #50      +/-   ##
==========================================
+ Coverage    44.5%   45.23%   +0.72%     
==========================================
  Files          60       61       +1     
  Lines        7026     7125      +99     
==========================================
+ Hits         3127     3223      +96     
- Misses       3899     3902       +3
Impacted Files Coverage Δ
dolfyn/adv/turbulence.py 42.5% <ø> (ø) :arrow_up:
dolfyn/adv/motion.py 61.04% <ø> (-0.23%) :arrow_down:
dolfyn/io/nortek.py 89.62% <100%> (+0.19%) :arrow_up:
dolfyn/test/test_rotate_adv.py 88.88% <100%> (+2.12%) :arrow_up:
dolfyn/rotate/rdi.py 92.85% <100%> (+2.15%) :arrow_up:
dolfyn/__init__.py 100% <100%> (ø) :arrow_up:
dolfyn/io/api.py 92.3% <100%> (ø) :arrow_up:
dolfyn/rotate/__init__.py 100% <100%> (ø) :arrow_up:
dolfyn/_version.py 76.47% <100%> (ø) :arrow_up:
dolfyn/rotate/signature.py 87.5% <66.66%> (-0.22%) :arrow_down:
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 44c4c9c...566f920. Read the comment docs.

lkilcher commented 5 years ago

@mcfogarty Other than addressing the only lingering comment above, I think this is finally ready to go! Thanks so much for all your help!

mcfogarty commented 5 years ago

Unfortunately, it's not working. I just reprocessed an RDI .000 file and dat.props['rotate_vars'] is still only {'vel'}