lkilcher / dolfyn

A library for oceanographic doppler instruments such as Acoustic Doppler Profilers (ADPs, ADCPs) and Acoustic Doppler Velocimeters (ADVs).
BSD 3-Clause "New" or "Revised" License
42 stars 25 forks source link

Heading bug fix mcf2 #51

Closed mcfogarty closed 5 years ago

mcfogarty commented 5 years ago

Apologies for undoing commits; should have tested in another branch.

Heading, pitch, roll outputs were checked for ADV w/IMU bench tests, as well as field data for ADV w/IMU on SMB and RDI workhorse on SMB. All calculations make sense.

Edits include fixing a few typos and adding (or requesting) more detail in comments.

mcfogarty commented 5 years ago

FYI when dat = dolfyn.read(fname_rdi + '.000', keep_orient_raw = True), the heading, pitch, and roll end up in dat.orient.raw, but heading_std, pitch_std, roll_std remain in dat.orient

lkilcher commented 5 years ago

Merging into my PR #50